Fixed issues related to flows and atoms initialization - #145
Conversation
| if "tendrl" in flow_fqn and "objects" in flow_fqn: | ||
| obj_name, flow_name = flow_fqn.split(".objects.")[-1].split( | ||
| obj_name = flow_fqn.split(".objects.")[-1].split( | ||
| ".flows.")[-2] |
There was a problem hiding this comment.
the older code was doing the same, whats the difference?
There was a problem hiding this comment.
Earlier we were trying to get obj_name and flow_name both in the same call. The value of obj_name used to be correct but flow name was not. Flow name used toe be reported as e.g. create_volume.CreateVolume whereas we need only CreateVolume, so we get these values separately now. Thats all...
466b06d to
f798fbb
Compare
| self.outputs = outputs or atom_def['outputs'] | ||
| self.uuid = uuid or atom_def['uuid'] | ||
| self.help = help or atom_def['help'] | ||
| self.inputs = inputs or atom_def.get('inputs')['mandatory'] |
There was a problem hiding this comment.
atom_def.get('inputs')['mandatory'] should be atom_def.get('inputs').get("mandatory")
| obj_name, flow_name = flow_fqn.split(".objects.")[-1].split( | ||
| obj_name = flow_fqn.split(".objects.")[-1].split( | ||
| ".flows.")[-2] | ||
| flow_name = flow_fqn.split(".objects.")[-1].split( |
There was a problem hiding this comment.
flow_name = flow_fqn.split(".flows.")[-1].split(".")[-1]
| if "tendrl" in flow_fqn and "objects" in flow_fqn: | ||
| obj_name, flow_name = flow_fqn.split(".objects.")[-1].split( | ||
| obj_name = flow_fqn.split(".objects.")[-1].split( | ||
| ".flows.")[-2] |
There was a problem hiding this comment.
obj_name = flow_fqn.split(".objects.")[-1].split(".")[0]
much cleaner
Signed-off-by: Shubhendu <shtripat@redhat.com>
|
Verified with latest create/delete pool changes and works as expected. |
2 participants
Signed-off-by: Shubhendu shtripat@redhat.com