Skip to content

ci: make Claude PR Review non-blocking when API limit hits#291

Merged
shuheng-liu merged 1 commit into
mainfrom
claude/ci-pass-with-exceptions-x8qZE
May 12, 2026
Merged

ci: make Claude PR Review non-blocking when API limit hits#291
shuheng-liu merged 1 commit into
mainfrom
claude/ci-pass-with-exceptions-x8qZE

Conversation

@shuheng-liu
Copy link
Copy Markdown
Member

What this does

Adds continue-on-error: true to the review job in .github/workflows/claude-pr-review.yml. When the Anthropic API rate limit is reached the action errors out and turns the PR check red, which currently makes the per-commit rollup show a ❌ even though every other CI passed. With this flag, GitHub reports the workflow run as success regardless of the job outcome, so the PR shows green; the failure itself is still visible in the Actions tab if you want to debug it, and manual review remains the fallback when the automated review can't run.

How it was tested

  • Inspected the one-line diff against .github/workflows/claude-pr-review.yml.
  • Ran pre-commit run --files .github/workflows/claude-pr-review.yml locally — yaml/zizmor/gitleaks/typos all pass.
  • End-to-end behavior is exercised by this PR itself: if the Claude PR Review job fails (e.g. rate-limited), the per-commit checkmark should still report green once other required checks pass.

How to checkout & try? (for the reviewer)

git fetch origin claude/ci-pass-with-exceptions-x8qZE
git checkout claude/ci-pass-with-exceptions-x8qZE
git diff main -- .github/workflows/claude-pr-review.yml

Checklist

  • I have added Google-style docstrings to important functions and ensured function parameters are typed.
  • My PR includes policy-related changes.
    • If the above is checked: I have run the GPU pytests (pytest -m "gpu") and regression tests.

Note: Before submitting this PR, please read the contributor guideline.


Generated by Claude Code

@shuheng-liu shuheng-liu self-assigned this May 12, 2026
@shuheng-liu shuheng-liu marked this pull request as ready for review May 12, 2026 17:21
@shuheng-liu shuheng-liu merged commit 5dfd5df into main May 12, 2026
5 of 6 checks passed
@shuheng-liu shuheng-liu deleted the claude/ci-pass-with-exceptions-x8qZE branch May 12, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant