ci: move Claude PR Review continue-on-error to step level#293
Merged
Conversation
shuheng-liu
added a commit
that referenced
this pull request
May 12, 2026
shuheng-liu
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Follow-up to #291. The previous PR put
continue-on-error: trueat the job level on thereviewjob, but GitHub's job-level flag only changes the workflow run's overall conclusion — the per-job check status still reflects the job's actual outcome, so thereviewcheck on a PR still showed ❌ when the action rate-limited (e.g. #292 run 25751881797). Moving the flag down onto theanthropics/claude-code-action@v1step instead masks the failure before it propagates to the job's conclusion, so the check run reports success and the per-commit ✓/✗ rollup goes green. Drops the now-redundant job-level flag.How it was tested
-continue-on-error: trueat the job and+continue-on-error: trueon the action step.pre-commit run --files .github/workflows/claude-pr-review.yml— clean (yaml/zizmor/gitleaks/typos).reviewcheck as green.How to checkout & try? (for the reviewer)
Checklist
Note: Before submitting this PR, please read the contributor guideline.
Generated by Claude Code