Skip to content

ci: move Claude PR Review continue-on-error to step level#293

Merged
shuheng-liu merged 1 commit into
mainfrom
claude/ci-pass-step-level-continue-on-error
May 12, 2026
Merged

ci: move Claude PR Review continue-on-error to step level#293
shuheng-liu merged 1 commit into
mainfrom
claude/ci-pass-step-level-continue-on-error

Conversation

@shuheng-liu
Copy link
Copy Markdown
Member

What this does

Follow-up to #291. The previous PR put continue-on-error: true at the job level on the review job, but GitHub's job-level flag only changes the workflow run's overall conclusion — the per-job check status still reflects the job's actual outcome, so the review check on a PR still showed ❌ when the action rate-limited (e.g. #292 run 25751881797). Moving the flag down onto the anthropics/claude-code-action@v1 step instead masks the failure before it propagates to the job's conclusion, so the check run reports success and the per-commit ✓/✗ rollup goes green. Drops the now-redundant job-level flag.

How it was tested

  • Single-line move, verified diff is exactly -continue-on-error: true at the job and +continue-on-error: true on the action step.
  • pre-commit run --files .github/workflows/claude-pr-review.yml — clean (yaml/zizmor/gitleaks/typos).
  • End-to-end behavior will be exercised by this PR itself: after merge, a fresh PR that hits the rate limit should report the review check as green.

How to checkout & try? (for the reviewer)

git fetch origin claude/ci-pass-step-level-continue-on-error
git checkout claude/ci-pass-step-level-continue-on-error
git diff main -- .github/workflows/claude-pr-review.yml

Checklist

  • I have added Google-style docstrings to important functions and ensured function parameters are typed.
  • My PR includes policy-related changes.
    • If the above is checked: I have run the GPU pytests (pytest -m "gpu") and regression tests.

Note: Before submitting this PR, please read the contributor guideline.


Generated by Claude Code

@shuheng-liu shuheng-liu self-assigned this May 12, 2026
@shuheng-liu shuheng-liu marked this pull request as ready for review May 12, 2026 18:04
@shuheng-liu shuheng-liu merged commit adeb3fd into main May 12, 2026
6 checks passed
@shuheng-liu shuheng-liu deleted the claude/ci-pass-step-level-continue-on-error branch May 12, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant