ci(codeql): run on push→main + weekly only, not on PRs#139
Closed
bastien-gallay wants to merge 1 commit into
Closed
ci(codeql): run on push→main + weekly only, not on PRs#139bastien-gallay wants to merge 1 commit into
bastien-gallay wants to merge 1 commit into
Conversation
CodeQL's Rust extractor must trace a full cargo build (no build-mode: none for Rust), so every run is a multi-minute cold compile of the iced-heavy app crate — and rust-cache barely helps a traced build. Running it on every PR put that compile on the critical path for no coverage a post-merge run doesn't give. Drop the pull_request trigger: SAST now lands on the merge-to-main run (plus the weekly baseline), catching regressions within minutes of merge instead of blocking the PR. Analyze (Rust) is therefore not a required check. Leak defense is unaffected — CodeQL never scanned for secrets; that is GitHub secret scanning + push protection (enabled). Sync docs/CI.md.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CodeQL is the slowest thing in CI. Its Rust extractor must trace a real
cargo build— there's nobuild-mode: nonefor Rust — so every run is amulti-minute cold compile of the
iced-heavyappcrate, andSwatinem/rust-cachebarely helps because a traced build can't reuse aprebuilt
target/. Running it on every PR put that compile on the criticalpath for coverage the post-merge run already provides.
What
pull_requesttrigger fromcodeql.yml; keeppush→main, weeklycron, and
workflow_dispatch.concurrency.cancel-in-progress→false(no PR runs left to cancel; nevercancel a baseline scan).
mainrun (plus weekly) — a regressionsurfaces within minutes of merge instead of blocking the PR.
Analyze (Rust)is therefore not a required check; branch protectionrequires only
ci-success.docs/CI.mdsynced (§1 table, §2 stages, §3 rationale).Leak defense is unaffected
CodeQL never detected secrets. Credential leaks are caught by GitHub
secret scanning + push protection, which I verified is enabled on this
repo — independent of this change.
🤖 Generated with Claude Code