fix: add failed test count diagnostic to ExitSummary#1070
Draft
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Draft
fix: add failed test count diagnostic to ExitSummary#1070Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Conversation
ExitSummary was missing the "Looks like you failed X test(s) of Y" diagnostic that Test::Builder provides. Users migrating from Test::More to Test2::Bundle::More expected this output. Closes Test-More#1056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing "Looks like you failed X test(s) of Y" diagnostic to
Test2::Plugin::ExitSummary.Why
Users migrating from
Test::MoretoTest2::Bundle::Moreexpect the failure count summary at the end of a test run (#1056).ExitSummaryalready tracked$hub->failedbut never reported it —Test::Builderdoes.How
Added a simple
$ctx->diag(...)block after the existing diagnostics insummary(), matching Test::Builder's format with proper singular/plural handling.Testing
t/modules/Plugin/ExitSummary.t(single failure + plural failures)Closes #1056