Skip to content

Enhancement stackinabox server error code#34

Closed
BenjamenMeyer wants to merge 2 commits into
masterfrom
enhancement_stackinabox_server_error_code
Closed

Enhancement stackinabox server error code#34
BenjamenMeyer wants to merge 2 commits into
masterfrom
enhancement_stackinabox_server_error_code

Conversation

@BenjamenMeyer

Copy link
Copy Markdown
Member

StackInABox returns 599 for bad routes instead of 500

BenjamenMeyer added 2 commits May 28, 2015 21:50
- Adds the ability have a StackInABox service embedded as a sub-service to another StackInABox service
  - Requires that the sub-service know the full URI that it will need to match its functions against
- StackInABox was returning 500 when it failed to find a matching route. This changes that specific error to 599 so it is clearer to the tester that it is a routing issue instead of a service issue.
@BenjamenMeyer BenjamenMeyer self-assigned this May 28, 2015
@BenjamenMeyer BenjamenMeyer added this to the 0.9 milestone May 28, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 3641bd9 on enhancement_stackinabox_server_error_code into * on master*.

@BenjamenMeyer

Copy link
Copy Markdown
Member Author

PR #35 made bigger changes that also covered the issue here. This PR is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants