Enhancement errors update#35
Merged
Merged
Conversation
BenjamenMeyer
commented
May 29, 2015
BenjamenMeyer
commented
Member
- Use specific error codes for certain events within StackInABox to make debugging easier
- returns 597 if the service is unknown
- returns 596 if an unhandled exception occurred within the service
- returns 595 if the service did not recognize the route
- Return 405 if the URI is handled but the specific METHOD on the URI is not.
- StackInABox was returning 500 when it failed to find a matching route. This changes that specific error to 599 so it is clearer to the tester that it is a routing issue instead of a service issue.
- For StackInABoxService, return 405 if the method is not implemented - For StackInABox, return 599 if the route is unknown, or 598 if the internal service generated an exception
- HTTPretty apparently requires mapping of response codes to its internal list of statuses with text values. - The 598 and 599 values conflicted in meanings with values HTTPretty was using, and 597 did not exist. - Updated the StackInABox status values to not conflict with HTTPretty - Updated to auto-insert the values into the list maintained by HTTPretty if the values do not already exist Note: We may want to adjust them again before the 1.0 release to provide a buffer between 598 and our own codes
|
Changes Unknown when pulling 2aa943c on enhancement_errors_update into * on master*. |
Conflicts: tools/test-requirements.txt - Added Upate for 'responses', version 0.4.0 supports Py3 - Updated minimum coverage to 88%
|
Changes Unknown when pulling 9ca7915 on enhancement_errors_update into * on master*. |
Member
Author
|
HTTPretty is having issues on TravisCI, but works locally. Merging anyway as it is not something we can solve. |
BenjamenMeyer
added a commit
that referenced
this pull request
May 29, 2015
Enhancement errors update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.