Supporting complex types in examples, and expanded expression parser to ...#122
Merged
JakeGinnivan merged 5 commits intoTestStack:examplesfrom Apr 30, 2014
Merged
Conversation
…to allow accessing properties on fields etc
Member
Author
There was a problem hiding this comment.
This blew up before. Much nicer now :)
Member
There was a problem hiding this comment.
Nice. Man I had to read the code again to understand how these tests worked!! Thanks for adding the tests.
Member
There was a problem hiding this comment.
Just wondering, do we need to test this as ApprovalTests? I mean this could be just a simple assertion and would probably read a lot better when it fails. Thoughts?
JakeGinnivan
added a commit
that referenced
this pull request
Apr 30, 2014
Supporting complex types in examples, and expanded expression parser to ...
Member
Author
|
Fixed all the review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...allow accessing properties on fields etc