-
Notifications
You must be signed in to change notification settings - Fork 84
Adds tests for textreporter & fixes a bug with exception reporting #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
...y.Tests/Reporters/TextReporter/TextReporterTests.ShouldProduceExpectedReport.approved.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| Story: Happiness | ||
| As a person | ||
| I want ice cream | ||
| So that I can be happy | ||
|
|
||
| Scenario: Happy Path Scenario [for Happiness] | ||
| Given a positive account balance | ||
| When the account holder requests money | ||
| Then money is dispensed | ||
|
|
||
|
|
||
| Story: Happiness | ||
| As a person | ||
| I want ice cream | ||
| So that I can be happy | ||
|
|
||
| Scenario: Sad Path Scenario [for Happiness] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Failed] [Boom] [Details at 1 below] | ||
|
|
||
| Exceptions: | ||
| 1. Boom | ||
| at TestStack.BDDfy.Tests.Reporters.ReportTestData.GetFailingExecutionSteps() in ...\ReportTestData.cs | ||
|
|
||
|
|
||
| Story: Happiness | ||
| As a person | ||
| I want ice cream | ||
| So that I can be happy | ||
|
|
||
| Scenario: Inconclusive Scenario [for Happiness] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Inconclusive] | ||
|
|
||
|
|
||
| Story: Happiness | ||
| As a person | ||
| I want ice cream | ||
| So that I can be happy | ||
|
|
||
| Scenario: Not Implemented Scenario [for Happiness] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Not implemented] | ||
|
|
||
|
|
||
|
|
||
| Scenario: Happy Path Scenario [with no story] | ||
| Given a positive account balance | ||
| When the account holder requests money | ||
| Then money is dispensed | ||
|
|
||
|
|
||
|
|
||
| Scenario: Sad Path Scenario [with no story] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Failed] [Boom] [Details at 1 below] | ||
|
|
||
| Exceptions: | ||
| 1. Boom | ||
| at TestStack.BDDfy.Tests.Reporters.ReportTestData.GetFailingExecutionSteps() in ...\ReportTestData.cs | ||
|
|
||
|
|
||
|
|
||
| Scenario: Inconclusive Scenario [with no story] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Inconclusive] | ||
|
|
||
|
|
||
|
|
||
| Scenario: Not Implemented Scenario [with no story] | ||
| Given a negative account balance [Passed] | ||
| When the account holder requests money [Passed] | ||
| Then no money is dispensed [Not implemented] | ||
|
|
||
|
|
||
| Story: Unhappy examples | ||
| As an unhappy examples story | ||
| I want to see failed steps | ||
| So that I can diagnose what's wrong | ||
|
|
||
| Scenario: Example Scenario | ||
| Given a <sign> account balance | ||
| When the account holder requests money | ||
| Then money <action> dispensed | ||
|
|
||
| Examples: | ||
| | sign | action | Result | Errors | | ||
| | positive | is | Passed | | | ||
| | negative | is not | Failed | Step: Then money <action> dispensed failed with exception: [Boom] [Details at 1 below] | | ||
|
|
||
| Exceptions: | ||
| 1. Boom | ||
| at TestStack.BDDfy.Tests.Reporters.ReportTestData.GetScenarios(Boolean includeFailingScenario, Boolean includeExamples) in ...\ReportTestData.cs | ||
|
|
||
|
|
||
| Story: Happy Examples | ||
| As a happy examples story | ||
| I want a clean report with examples | ||
| So that the report is clean and readable | ||
|
|
||
| Scenario: Example Scenario | ||
| Given a <sign> account balance | ||
| When the account holder requests money | ||
| Then money <action> dispensed | ||
|
|
||
| Examples: | ||
| | sign | action | | ||
| | positive | is | | ||
| | negative | is not | | ||
|
|
||
|
|
||
29 changes: 29 additions & 0 deletions
29
TestStack.BDDfy.Tests/Reporters/TextReporter/TextReporterTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| using System.Runtime.CompilerServices; | ||
| using System.Text; | ||
| using ApprovalTests; | ||
| using NUnit.Framework; | ||
| using TestStack.BDDfy.Reporters; | ||
|
|
||
| namespace TestStack.BDDfy.Tests.Reporters.MarkDown | ||
| { | ||
| [TestFixture] | ||
| public class TextReporterTests | ||
| { | ||
| [Test] | ||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| public void ShouldProduceExpectedReport() | ||
| { | ||
| var stories = new ReportTestData().CreateMixContainingEachTypeOfOutcomeWithOneScenarioPerStory(); | ||
| var actual = new StringBuilder(); | ||
|
|
||
| foreach (var story in stories) | ||
| { | ||
| var textReporter = new TextReporter(); | ||
| textReporter.Process(story); | ||
| actual.AppendLine(textReporter.ToString()); | ||
| } | ||
|
|
||
| Approvals.Verify(actual.ToString(), StackTraceScrubber.Scrub); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the boom the second step so the last step is not executed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to test the
TextReporter. That is (or should be) thoroughly tested elsewhere. Is it not working?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have removed ordering constraints, the existing tests do not cover when you mix order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the mixed order is not tested. We have to add some for for the mixed order to the existing tests.