Skip to content

Updated markdown report for examples#126

Merged
JakeGinnivan merged 2 commits intoTestStack:examplesfrom
JakeGinnivan:MarkdownReport
May 2, 2014
Merged

Updated markdown report for examples#126
JakeGinnivan merged 2 commits intoTestStack:examplesfrom
JakeGinnivan:MarkdownReport

Conversation

@JakeGinnivan
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples aren't coming out in markdown. It's just showing as Given a account balance

@JakeGinnivan
Copy link
Copy Markdown
Member Author

Fixed the issue you found. Thanks!

JakeGinnivan added a commit that referenced this pull request May 2, 2014
Updated markdown report for examples
@JakeGinnivan JakeGinnivan merged commit bc22ded into TestStack:examples May 2, 2014
@JakeGinnivan JakeGinnivan deleted the MarkdownReport branch May 2, 2014 15:30
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown itself doesn't have html tables and if one wants html reports in pure markdown spec they'll have to write it with html table tags which I think would suck. The alternative solution would be to use GFM which does support markdown but the syntax is different. More info here. I think we should fix this as this isn't proper markdown file anymore.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just done a text table as a code block

Could be a configuration option to do markdown extra which has tables. The end result would be putting the 4 spaces, or not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Since I don't know how the GFM actually works I am going to try a few options here. GitHub will show us which one is good:

| sign | action | Result | Errors |
| positive | is | Passed | |
| negative | is not | Failed | Step: Then money <action> dispensed failed with exception|

sign action Result Errors
positive is Passed
negative is not Failed Step: Then money <action> dispensed failed with exception
sign action Result Errors
positive is Passed
negative is not Failed Step: Then money ; dispensed failed with exception

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. So it seems like we need to add the header separator row with |----|'s and we DO need to escape <>.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't think this needs a configuration options. Both changes are sensible in and out of GitHub or any other viewer with markdown table support.

@MehdiK
Copy link
Copy Markdown
Member

MehdiK commented May 3, 2014

Thanks for this @JakeGinnivan. There were a few issues that I commented on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants