Skip to content

Report tests#77

Merged
mwhelan merged 16 commits intoTestStack:masterfrom
MehdiK:report-tests
Mar 31, 2014
Merged

Report tests#77
mwhelan merged 16 commits intoTestStack:masterfrom
MehdiK:report-tests

Conversation

@MehdiK
Copy link
Copy Markdown
Member

@MehdiK MehdiK commented Mar 30, 2014

Based on @mwhelan's #74 to fix the html test's approval test

@MehdiK MehdiK mentioned this pull request Mar 30, 2014
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be an embedded resource?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. However you want to discover it is fine. Just need to get the html into the test....

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now only handled using ApprovalTests; so I guess this could be just a file included in the solution. You're cool with that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sounds good!

On Sun, Mar 30, 2014 at 2:54 PM, Mehdi Khalili notifications@github.comwrote:

In TestStack.BDDfy.Tests/TestStack.BDDfy.Tests.csproj:

@@ -137,6 +147,9 @@


It's now only handled using ApprovalTests; so I guess this could be just a
file included in the solution. You're cool with that?

Reply to this email directly or view it on GitHubhttps://github.com//pull/77/files#r11098078
.

@MehdiK
Copy link
Copy Markdown
Member Author

MehdiK commented Mar 30, 2014

@mwhelan I really like what you've done here. Thanks a lot for the great effort.

I made a few very small changes if you don't mind. I'd appreciate if you could please review. Thanks.

mwhelan added a commit that referenced this pull request Mar 31, 2014
@mwhelan mwhelan merged commit 2c1171f into TestStack:master Mar 31, 2014
@MehdiK MehdiK deleted the report-tests branch March 31, 2014 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants