Skip to content

Fixed a bug in GetTypesToTest #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkozmic merged 2 commits into from
Jul 13, 2012
Merged

Fixed a bug in GetTypesToTest #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5104878
Fixed a bug in GetTypesToTest - the tests would fail if .net runtime …
MehdiK Jul 13, 2012
66b56fb
ignored a few file types ETC
MehdiK Jul 13, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,13 @@ bin
obj

# mstest test results
TestResults
TestResults

# Misc
_ReSharper.*
*.user
*.suo
*.crunchproject.local.xml
*.crunchsolution.local.xml
*.ncrunchsolution
*.ncrunchproject
20 changes: 16 additions & 4 deletions ConventionTests/ConventionTests.NUnit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,22 @@ protected virtual Assembly[] GetAssembliesToScan(ConventionData data)
protected virtual Type[] GetTypesToTest(ConventionData data)
{
return
GetAssembliesToScan(data).SelectMany(a => a.GetTypes()).Where(data.Types.Invoke).OrderBy(t => t.FullName)
.ToArray();
}
}
GetAssembliesToScan(data).SelectMany(GetTypesSafely).Where(data.Types.Invoke).OrderBy(t => t.FullName)
.ToArray();
}

private static IEnumerable<Type> GetTypesSafely(Assembly assembly)
{
try
{
return assembly.GetTypes();
}
catch (ReflectionTypeLoadException ex)
{
return ex.Types.Where(x => x != null);
}
}
}

public abstract class WindsorConventionTest<TDiagnostic> : WindsorConventionTest<TDiagnostic, IHandler>
where TDiagnostic : class, IDiagnostic<IEnumerable<IHandler>>, IDiagnostic<object>
Expand Down