Added remaining Person data sources#6
Merged
robdmoore merged 2 commits intoTestStack:anonymous-valuesfrom Sep 19, 2014
mwhelan:anonymous-values
Merged
Added remaining Person data sources#6robdmoore merged 2 commits intoTestStack:anonymous-valuesfrom mwhelan:anonymous-values
robdmoore merged 2 commits intoTestStack:anonymous-valuesfrom
mwhelan:anonymous-values
Conversation
… some incorrectly named tests, removed Guard class
Member
Author
There was a problem hiding this comment.
A question of preference. I just added the variables in to see what was happening. I probably should have reverted it back to what it was originally (removed the comments)
Member
|
Love this PR. Nice work. That ncrunch file is a bit weird though :P |
robdmoore
added a commit
that referenced
this pull request
Sep 19, 2014
Added remaining Person data sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also addressed most of the issues in the code review and started adding XML comment to a number of classes.