Fix to NRE when redirect to action without specified controller #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Is it worth including the action they tried to redirect to in the error message and maybe change "with default controller" to "within the same controller"?
Contributor
Author
There was a problem hiding this comment.
I like the 'within the same controller'. Wasn't sure how to call it so I just left the 'default'.
Member
|
Looks great - just that one comment I've added. |
Contributor
Author
|
I have changed the assertion message. |
robdmoore
added a commit
that referenced
this pull request
Feb 12, 2014
Fix to NRE when redirect to action without specified controller
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to the issue number #13