Skip to content

Conversation

@robdmoore
Copy link
Member

cc @MehdiK

@MehdiK
Copy link
Member

MehdiK commented Sep 19, 2013

Cool. Thanks. The samples are great. I would remove the regions though :p

@MehdiK
Copy link
Member

MehdiK commented Sep 19, 2013

I would also replace Example with Sample in the folder and project names to make it consistent with other projects.

@robdmoore
Copy link
Member Author

I know there is a lot of hate for regions out there and most of the time I agree. Interestingly though, I've recently taken to hiding the setup, instance vars, private helpers and tear down (if present) away behind a Setup region to remove the visual clutter and allow maintainers to see and focus on the tests themselves. I only do it when the setup gets bigger than a certain amount.

@robdmoore
Copy link
Member Author

Cool - will do

@mwhelan
Copy link
Member

mwhelan commented Sep 20, 2013

oh noes! :-)

On Fri, Sep 20, 2013 at 12:01 AM, Robert Moore notifications@github.comwrote:

I know there is a lot of hate for regions out there and most of the time I
agree. Interestingly though, I've recently taken to hiding the setup,
instance vars, private helpers and tear down (if present) away behind a
Setup region to remove the visual clutter and allow maintainers to see and
focus on the tests themselves. I only do it when the setup gets bigger than
a certain amount.


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-24779792
.

@JakeGinnivan
Copy link
Member

Not a good enough reason to use regions :P

My only acceptable time is wpf dependency properties. They are verbose and there is nothing you can do about them. Even then, im not convinced :)

Sent from my Windows Phone


From: Robert Mooremailto:notifications@github.com
Sent: ý20/ý09/ý2013 00:01
To: TestStack/TestStack.FluentMVCTestingmailto:TestStack.FluentMVCTesting@noreply.github.com
Subject: Re: [TestStack.FluentMVCTesting] Example project (#8)

I know there is a lot of hate for regions out there and most of the time I agree. Interestingly though, I've recently taken to hiding the setup, instance vars, private helpers and tear down (if present) away behind a Setup region to remove the visual clutter and allow maintainers to see and focus on the tests themselves. I only do it when the setup gets bigger than a certain amount.


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-24779792.

@robdmoore
Copy link
Member Author

Done :)

MehdiK added a commit that referenced this pull request Sep 20, 2013
@MehdiK MehdiK merged commit d334bcd into TestStack:master Sep 20, 2013
@MehdiK
Copy link
Member

MehdiK commented Sep 20, 2013

Thanks mate :)

@MehdiK
Copy link
Member

MehdiK commented Sep 20, 2013

I asked @robdmoore to rename his sample folder and project names to Sample for consistency. Can we please make this consistent across the board? It's already almost there. Just takes small adjustments :) /cc @JakeGinnivan @kkozmic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants