Grid updates and new tests #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calized versions of Windows and VS (the Name property can be in different language rather than English). Add: controls added to corresponding versions of TestApplications. Tests for these controls added to TestStack.White.UITests project. Fix: Old test for message box fixed for running in localized versions of Windows and VS (the button's Name property is in current locale language).
…ct and in WhiteCore project FIX: DataGrid test divided into two separate files (for wpf and winforms)
Member
There was a problem hiding this comment.
I don't think this comment is required. Change is fair enough by itemself
Contributor
Author
There was a problem hiding this comment.
As you say, should I remove it?
Member
|
Looks good, if you could just respond to my questions im happy to pull this in |
Member
|
Superseded by #129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: searching Rows and Cells in Table (Winforms.DataGridView) for localized versions of Windows and VS (the Name property can be in different language rather than English).
Add: controls added to corresponding versions of TestApplications. Tests for these controls added to TestStack.White.UITests project.
Fix: Old test for message box fixed for running in localized versions of Windows and VS (the button's Name property is in current locale language).
Add: menu double click tests (to Issue #49)
UI and Unit tests pass (except for the one that failed before any changes). Can't fully run UITests.Old because on my home computer they partly pass because of localization issues described above - all Table retrieving needed to be localy unrelated and also many tests fail because in Assertions english type names used while i get localized (this however doesn't affect on elements retrieving except for some parts of the WinForms.Tables). Previously I ran tests at work where I don't have these issues with localizations but now I can't do that.