feat: add options to constructor of MockFileSystem #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mergify merged 6 commits into TestableIO:main from vbreuss:topic/vb/add-option-to-not-create-temp-dir

Jul 31, 2023

Member

vbreuss commented Jul 30, 2023

Add a new class MockFileSystemOptions and corresponding overloads in the constructor of MockFileSystem.
Default values don't change the current behaviour, but when setting CreateDefaultTempDir to false, the temp directory is not created.

Fixes:

Creation of the default "temp" directory in MockFileSystem should have a toggle #983

vbtig added 4 commits

July 30, 2023 09:01


          Add MockFileSystemOptions and overloads in constructor of MockFileSystem

1c287df


          Fix file ending

8edb89b


          Handle null as options

aaf7f73


          Use XFS.Path in tests

8887d4a

vbreuss changed the title ~~feat: Add MockFileSystemOptions and overloads in constructor of MockFileSystem~~ feat: Add options to constructor of MockFileSystem

vbreuss changed the title ~~feat: Add options to constructor of MockFileSystem~~ feat: add options to constructor of MockFileSystem

fgreinacher reviewed

View reviewed changes

src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystemOptions.cs Outdated Show resolved Hide resolved

vbreuss added 2 commits

July 31, 2023 16:09


          Merge branch 'main' into topic/vb/add-option-to-not-create-temp-dir

f162664


          Use IsExternalInit and change option properties to init-only

df7029c

fgreinacher approved these changes

View reviewed changes

Contributor

fgreinacher left a comment

Thanks for the rework, LGTM!

mergify bot merged commit baecc07 into TestableIO:main

vbreuss referenced this pull request in Testably/Testably.Abstractions


          chore(deps): update dependency testableio.system.io.abstractions to v…

39f2325

…19.2.51 (#345)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.29` -> `19.2.51` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v19.2.51`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.51)

##### What's Changed

- feat: add options to constructor of MockFileSystem by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1013](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1013)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.50...v19.2.51

###
[`v19.2.50`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.50)

##### What's Changed

- chore(deps): update dependency githubactionstestlogger to v2.2.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/991](https://togithub.com/TestableIO/System.IO.Abstractions/pull/991)
- chore(deps): update dependency githubactionstestlogger to v2.2.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/992](https://togithub.com/TestableIO/System.IO.Abstractions/pull/992)
- chore(deps): update dependency coverlet.collector to v6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/993](https://togithub.com/TestableIO/System.IO.Abstractions/pull/993)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.21 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/994](https://togithub.com/TestableIO/System.IO.Abstractions/pull/994)
- chore(deps): update dependency nerdbank.gitversioning to v3.6.133 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/995](https://togithub.com/TestableIO/System.IO.Abstractions/pull/995)
- chore(deps): update dependency githubactionstestlogger to v2.3.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/996](https://togithub.com/TestableIO/System.IO.Abstractions/pull/996)
- chore(deps): update dependency nunit3testadapter to v4.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/997](https://togithub.com/TestableIO/System.IO.Abstractions/pull/997)
- chore(deps): update dependency githubactionstestlogger to v2.3.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/998](https://togithub.com/TestableIO/System.IO.Abstractions/pull/998)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1000](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1000)
- chore(deps): update dependency githubactionstestlogger to v2.3.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/999](https://togithub.com/TestableIO/System.IO.Abstractions/pull/999)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1002](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1002)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.22 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1003](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1003)
- chore(deps): update dependency dotnet-sdk to v7.0.304 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1004](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1004)
- chore(deps): update dependency dotnet-sdk to v7.0.305 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1005](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1005)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1006](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1006)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.23 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1007](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1007)
- chore(deps): update dependency benchmarkdotnet to v0.13.6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1008](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1008)
- chore(deps): update dotnet/nbgv action to v0.4.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1010](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1010)
- chore(deps): update dependency dotnet-sdk to v7.0.306 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1011](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1011)
- docs: mention correct package to install in README.md by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1014](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1014)
- feat: implement Path.GetRelativePath in MockFileSystem by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1012](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1012)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.29...v19.2.50

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

vbreuss deleted the topic/vb/add-option-to-not-create-temp-dir branch

August 1, 2023 04:11

vbreuss mentioned this pull request

Creation of the default "temp" directory in MockFileSystem should have a toggle #983

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet