feat: add support for TimeZoneInfo in abstractions#1046
Merged
Conversation
Introduces a new time-system abstraction for `System.TimeZoneInfo`, aligning it with the existing `ITimeSystem` pattern and extending parity tests to cover the new API. - Introduces `ITimeZoneInfo` (exposing the environment-coupled statics `Local`, `Utc`, `FindSystemTimeZoneById` and `GetSystemTimeZones`) and wires it into `ITimeSystem`. - Implements real-time support via `TimeZoneInfoWrapper` and exposes it from `RealTimeSystem`. - Extends parity test helpers/tests to validate the abstraction against `System.TimeZoneInfo` (with static-method exclusions for the members that are intentionally not abstracted).
Test Results 1 files - 101 1 suites - 101 2s ⏱️ - 2h 25m 29s Results for commit 75d3e53. ± Comparison against base commit c4e0fd4. This pull request removes 112593 tests. |
|
This is addressed in release v7.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new time-system abstraction for
System.TimeZoneInfo, aligning it with the existingITimeSystempattern and extending parity tests to cover the new API.ITimeZoneInfo(exposing the environment-coupled staticsLocal,Utc,FindSystemTimeZoneByIdandGetSystemTimeZones) and wires it intoITimeSystem.TimeZoneInfoWrapperand exposes it fromRealTimeSystem.System.TimeZoneInfo(with static-method exclusions for the members that are intentionally not abstracted).