Print chat cells as a flat event log (textql_sdk.cell_render) - #27
Merged
Conversation
The example rendered every cell snapshot identically, so a cell mid-execution was indistinguishable from a finished one, per-cell failures were invisible, and the incremental-print logic assumed cell text only ever grows. - Branch on `cell.complete` rather than comparing `lifecycle` to LIFECYCLE_EXECUTED. `Complete` is set from a polymorphic `IsComplete()`: non-executable cells (markdown, text) are complete at LIFECYCLE_CREATED, executable ones at EXECUTED or HALTED. Comparing lifecycle directly marks every markdown cell as never finishing. - Surface LIFECYCLE_EXECUTING and LIFECYCLE_HANDOFF_PENDING so long-running cells read as in-flight. - Report `exec_error` per cell. A run reaches run_complete even when individual cells failed, so run_error alone misses them; run_complete now summarises failed and non-terminal cells. - Treat each event as a full snapshot: print a delta only when text grew monotonically, otherwise reprint. Slicing a delta out of replaced content (a SQL cell swapping query for query + results) printed garbage. Document the same rules in STREAMING.md.
The streaming bridge builds its own Connect transport (pyqwest) and never sees the httpx client on the Textql SDK, so there was no way to give streaming a private CA — `verify=` on the SDK only covered unary REST calls. - Thread `http_client` through create_streaming_client, create_connect_client and their sync variants, so callers can supply a pyqwest client. Defaults to None, which keeps the shared default transport and today's behaviour. - watch_chat example reads TEXTQL_CA_BUNDLE and applies it to both stacks. - Document the sharp edge: an HTTPTransport you construct yourself starts with an empty trust store, so a CA bundle without tls_include_system_certs=True fails every TLS handshake rather than just the private-CA ones. Verified empirically — bare HTTPTransport() cannot reach app.textql.com, while the shared default transport can. Also switch the example to MODEL_SONNET_4_6. Verified: pyright clean on streaming.py (the CI gate) and pylint 10.00/10 on both files; example imports and the render path re-checked against real protobuf messages. The ~18.5k pyright errors under src/_connect are pre-existing generated-code noise and untouched here.
fe/src/lib/clients/WatchChatClient.ts is the reference consumer of this stream. Compared against it, the example was missing resume and reconnect entirely: a dropped connection ended the run, and a retry would have replayed the chat from the beginning. - Track `event.cursor` on every event and `cell.id` on cells reporting complete, then replay both as resume_cursor / latest_complete_cell_id. Same checkpointing the frontend does (WatchChatClient.ts:248-260). - Reconnect with exponential backoff, 7 attempts from 500ms, matching MAX_RECONNECT_ATTEMPTS / BASE_RECONNECT_DELAY_MS. Treat a dropped transport as routine; run_error stays terminal and does not retry. - Handle the handoff_pending event instead of silently dropping it. Already at parity and unchanged: snapshot-replace by cell id (the store's updateMessageInPlace does the same), branching on `complete` rather than lifecycle (WatchChatClient uses it for the resume checkpoint, and hasMidExecutionCell tests `generated && !complete`), and per-cell exec_error rather than only run_error. Verified with a fake stream that drops mid-run: the retry carries latest_complete_cell_id=cell-A and resume_cursor=c2, then completes. pyright clean on streaming.py, pylint 10.00/10 on both files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
textql_sdk.cell_render, a handwritten module that prints a chatCellthe way the v2 SSE stream (POST /v2/chats/stream) presents it: a flat event log where an execution step appears twice — once when it starts running, carrying the query or code the model generated, and once when it finishes, carrying the result.watch_chatre-sends a full snapshot on every update, soCellPrintercollapses those to those two events, keyed on(cell.id, done).A
Cellis a oneof over ~50 payload types.CELL_INPUTSnames the input fields per type; everything else the server set is printed directly off the protobuf descriptors, so an unfamiliar cell type still shows its contents instead of a placeholder. Nothing is truncated. The registries are plain module-level dicts, so callers can reassign them.Also
examples/watch_chat.pynow usesCellPrinterand is back to streaming concerns only (create, watch, resume, reconnect).streaming.py(http_client=), so a private CA can be handed to the Connect stack as well as httpx.STREAMING.mdgains a "Printing cells" section.Testing
Exercised against synthetic cell snapshots: SQL (running / done / failed / connector auth hold), Python with images, charts and dataframes, web search, MCP, prose (
md/ans/summary— noteSummaryCellkeeps its text insummary, notcontent), thinking cells (hidden when the payload is empty, matchingisHiddenThinkingCell), empty oneof, and a 60-line Python cell to confirm nothing is elided. pylint 10.00/10 againstpylintrc; pyright clean on the new module.🤖 Generated with Claude Code