Add flag to render in binary/decimal suffix in DownloadColumn - #380
Conversation
Add a test for rendering binary suffix in test_progress.py
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 99.59% 99.42% -0.17%
==========================================
Files 52 51 -1
Lines 4441 4379 -62
==========================================
- Hits 4423 4354 -69
- Misses 18 25 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@willmcgugan I have added the discussed feature, let me know in case anything else is required |
willmcgugan
left a comment
There was a problem hiding this comment.
Rather than "decimal_suffix", let's call it "binary_units" which should default to False.
| """ | ||
|
|
||
| def __init__(self, decimal_suffix: bool = True) -> None: | ||
| self.decimal_ssuffix = decimal_suffix |
There was a problem hiding this comment.
Note typo in attribute name
|
@willmcgugan Sorry for some unnecessary commits, I think this should be it let me know in case you need something else, should I also resolve conflicts in Changelog? |
|
LGTM. Thanks. |
Add a test for rendering binary suffix in test_progress.py
Type of changes
Checklist
Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
An additional feature in #323