fix: resolve inline app duplicate frame stacking and height bounding - #6673
Open
Jyotish08 wants to merge 1 commit into
Open
fix: resolve inline app duplicate frame stacking and height bounding#6673Jyotish08 wants to merge 1 commit into
Jyotish08 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue or discussion
Fixes #6671
Description
Resolves two related bugs occurring with
App.run(inline=True)when the terminal is resized after rendering at least one frame:\x1b[?7l) inlinux_inline_driver.pywhile the inline application is running. This prevents drift between physical cursor tracking and internal state during resize events, and removes the full screen clear (\x1b[2J) on resize to preserve terminal scrollback.get_content_heightinlayout.pyto check usinganyinstead ofallwhen evaluating dynamic height children. This allows inline apps with mixed layout elements to properly expand up to the available terminal height.Changes Made
src/textual/drivers/linux_inline_driver.py: Managed auto-wrap escape codes and adjusted resize handling logic.src/textual/layout.py: Updated child dynamic height evaluation logic inget_content_height.