ci: diag for reviewdog "not PullRequest build" on clang-tidy-bazel-post#10555
Merged
maliberty merged 1 commit intoMay 30, 2026
Conversation
Reviewdog v0.21.0 emits "this is not PullRequest build" and posts nothing on fork-PR runs, even though the synthesized pull_request payload parses fine in a local reproduction. Suspect step-level `env:` cannot override runner-protected GITHUB_EVENT_PATH / GITHUB_EVENT_NAME under `workflow_run`, so reviewdog reads the workflow_run event instead of the synth file. Add a step (gated on `runner.debug == '1'`) that dumps the env reviewdog will see and the effective GITHUB_EVENT_PATH content, plus `-log-level=debug` on the reviewdog invocation under the same gate. Off the debug re-run path the workflow behaves exactly as before. Signed-off-by: Joao Luis Sombrio <sombrio@sombrasoft.dev>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
maliberty
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reviewdog: this is not PullRequest build.on every fork-PR run ofclang-tidy-bazel-post, so review comments never get posted. Confirmed across PRs dpl: speed up negotiation seeding with a row-bucketed spatial index #10550, syn: Allocate matches efficiently #10553 (multiple SHAs), dpl: modify default algorithm to negotiation legalizer #10226.GITHUB_ACTIONS=true,GITHUB_EVENT_NAME=pull_request,GITHUB_EVENT_PATH=event.jsonreaches the diff-fetch API call (401 on dummy token). So the payload shape parses correctly. Bug is in CI runtime env.env:cannot override runner-protectedGITHUB_EVENT_PATH/GITHUB_EVENT_NAMEunderworkflow_run, so reviewdog reads the workflow_run event payload (nopull_request.number) instead of our synth file.This PR adds a diagnostic step before
Run reviewdog, gated onrunner.debug == '1', that dumps:env | grep ^(GITHUB_|RUNNER_|REVIEWDOG_)GITHUB_EVENT_PATHand the contents of that filesteps.event.outputs.event_pathpathPlus
-log-level=debugon reviewdog under the same gate. Off the debug re-run path the workflow is identical to today.Constraint
workflow_runalways executes the listener from the default branch, so this diagnostic only fires once it lands on public master. Plan: merge here, propagate private → staging → public, then trigger a debug re-run on any open fork PR to capture the env dump.Test plan
clang-tidy-bazel-poston an open fork PR with "Enable debug logging" checked.GITHUB_EVENT_PATHin the env dump matches our synth path or the runner's workflow_run event path.