Conversation
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
…Vt swaps) Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| int start_index = expanded->startIndex(); | ||
| for (int i = start_index; i < path_length; i++) { | ||
| PathRef* path = expanded->path(i); | ||
| Vertex* path_vertex = path->vertex(sta_); |
There was a problem hiding this comment.
warning: Value stored to 'path_vertex' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
Vertex* path_vertex = path->vertex(sta_);
^src/rsz/src/RepairSetup.cc:402: Value stored to 'path_vertex' during its initialization is never read
Vertex* path_vertex = path->vertex(sta_);
^| int start_index = expanded->startIndex(); | ||
| for (int i = start_index; i < path_length; i++) { | ||
| PathRef* path = expanded->path(i); | ||
| Vertex* path_vertex = path->vertex(sta_); |
There was a problem hiding this comment.
warning: unused variable 'path_vertex' [clang-diagnostic-unused-variable]
Vertex* path_vertex = path->vertex(sta_);
^| if (i > 0 && network_->isDriver(path_pin) | ||
| && !network_->isTopLevelPort(path_pin)) { | ||
| TimingArc* prev_arc = expanded->prevArc(i); | ||
| Edge* prev_edge = path->prevEdge(prev_arc, sta_); |
There was a problem hiding this comment.
warning: Value stored to 'prev_edge' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
Edge* prev_edge = path->prevEdge(prev_arc, sta_);
^src/rsz/src/RepairSetup.cc:407: Value stored to 'prev_edge' during its initialization is never read
Edge* prev_edge = path->prevEdge(prev_arc, sta_);
^| if (i > 0 && network_->isDriver(path_pin) | ||
| && !network_->isTopLevelPort(path_pin)) { | ||
| TimingArc* prev_arc = expanded->prevArc(i); | ||
| Edge* prev_edge = path->prevEdge(prev_arc, sta_); |
There was a problem hiding this comment.
warning: unused variable 'prev_edge' [clang-diagnostic-unused-variable]
Edge* prev_edge = path->prevEdge(prev_arc, sta_);
^|
|
||
| // Check if we have already dealt with this instance. Skip if the answer | ||
| // is a yes. | ||
| if (instance_set.find(drvr) == instance_set.end()) |
There was a problem hiding this comment.
warning: statement should be inside braces [google-readability-braces-around-statements]
| if (instance_set.find(drvr) == instance_set.end()) | |
| if (instance_set.find(drvr) == instance_set.end()) { |
src/rsz/src/RepairSetup.cc:446:
- else
+ } else| if (pin1 != nullptr && pin2 != nullptr) { | ||
| // Swap the ports and nets | ||
| sta_->disconnectPin(found_pin1); | ||
| sta_->connectPin(inst, port1, net2); |
There was a problem hiding this comment.
warning: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
sta_->connectPin(inst, port1, net2);
^src/rsz/src/Resizer.cc:876: 'port1' declared without an initial value
LibertyPort *port1, *port2;
^src/rsz/src/Resizer.cc:885: Loop condition is false. Execution continues on line 902
while (pin_iter->hasNext()) {
^src/rsz/src/Resizer.cc:901: Assuming the condition is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Left side of '&&' is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Assuming the condition is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Taking true branch
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:904: 2nd function call argument is an uninitialized value
sta_->connectPin(inst, port1, net2);
^| sta_->disconnectPin(found_pin1); | ||
| sta_->connectPin(inst, port1, net2); | ||
| sta_->disconnectPin(found_pin2); | ||
| sta_->connectPin(inst, port2, net1); |
There was a problem hiding this comment.
warning: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
sta_->connectPin(inst, port2, net1);
^src/rsz/src/Resizer.cc:876: 'port2' declared without an initial value
LibertyPort *port1, *port2;
^src/rsz/src/Resizer.cc:885: Loop condition is true. Entering loop body
while (pin_iter->hasNext()) {
^src/rsz/src/Resizer.cc:889: Assuming 'port' is equal to 'pin1'
if (port == pin1) {
^src/rsz/src/Resizer.cc:889: Taking true branch
if (port == pin1) {
^src/rsz/src/Resizer.cc:894: Assuming 'port' is not equal to 'pin2'
if (port == pin2) {
^src/rsz/src/Resizer.cc:894: Taking false branch
if (port == pin2) {
^src/rsz/src/Resizer.cc:885: Loop condition is false. Execution continues on line 902
while (pin_iter->hasNext()) {
^src/rsz/src/Resizer.cc:901: Assuming the condition is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Left side of '&&' is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Assuming the condition is true
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:901: Taking true branch
if (pin1 != nullptr && pin2 != nullptr) {
^src/rsz/src/Resizer.cc:906: 2nd function call argument is an uninitialized value
sta_->connectPin(inst, port2, net1);
^| if (net && !port->direction()->isAnyTristate()) | ||
| parasiticsInvalid(net); |
There was a problem hiding this comment.
warning: statement should be inside braces [google-readability-braces-around-statements]
| if (net && !port->direction()->isAnyTristate()) | |
| parasiticsInvalid(net); | |
| if (net && !port->direction()->isAnyTristate()) { | |
| parasiticsInvalid(net); | |
| } |
| auto port_iter = sta::LibertyCellPortIterator(cell); | ||
| while (port_iter.hasNext()) { | ||
| LibertyPort *port = port_iter.next(); | ||
| if (!input_port->equiv(input_port, port) && |
There was a problem hiding this comment.
warning: static member accessed through instance [readability-static-accessed-through-instance]
| if (!input_port->equiv(input_port, port) && | |
| if (!sta::LibertyPort::equiv(input_port, port) && |
| while (port_iter.hasNext()) { | ||
| LibertyPort *port = port_iter.next(); | ||
| if (!input_port->equiv(input_port, port) && | ||
| !drvr_port->equiv(drvr_port, port) && |
There was a problem hiding this comment.
warning: static member accessed through instance [readability-static-accessed-through-instance]
| !drvr_port->equiv(drvr_port, port) && | |
| !sta::LibertyPort::equiv(drvr_port, port) && |
1 participant
No description provided.