drt: fix error when using custom vias in NDR#3250
Merged
eder-matheus merged 8 commits intoThe-OpenROAD-Project:masterfrom Apr 25, 2023
Merged
drt: fix error when using custom vias in NDR#3250eder-matheus merged 8 commits intoThe-OpenROAD-Project:masterfrom
eder-matheus merged 8 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
QuantamHD
reviewed
Apr 25, 2023
src/drt/src/dr/FlexDR_maze.cpp
Outdated
Comment on lines
+2340
to
+2341
| if (net->getFrNet()->getNondefaultRule() | ||
| && net->getFrNet()->getNondefaultRule()->getPrefVia(currZ)) | ||
| via = net->getFrNet()->getNondefaultRule()->getPrefVia(currZ); | ||
| && net->getFrNet()->getNondefaultRule()->getPrefVia( |
Collaborator
There was a problem hiding this comment.
Extracting net->getFrNet()->getNondefaultRule() into its own variable will help the readability of this section.
maliberty
approved these changes
Apr 25, 2023
Member
maliberty
left a comment
maliberty
left a comment
There was a problem hiding this comment.
Please fix Ethan's comment before merging
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3125