Naming style2#7733
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
… master) Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| unsigned short successBroadcast | ||
| JobMessage result(JobMessage::kSuccess); | ||
| std::string msg_str; | ||
| unsigned short success_broadcast |
There was a problem hiding this comment.
warning: consider replacing 'unsigned short' with 'uint16_t' [google-runtime-int]
unsigned short success_broadcast
^| } | ||
| std::string split; | ||
| while (getNextMsg(resultStr, JobMessage::EOP, split)) { | ||
| while (getNextMsg(result_str, JobMessage::kEop, split)) { |
There was a problem hiding this comment.
warning: 1st argument 'result_str' (passed to 'haystack') looks like it might be swapped with the 3rd, 'split' (passed to 'result') [readability-suspicious-call-argument]
while (getNextMsg(result_str, JobMessage::kEop, split)) {
^Additional context
src/dst/src/Distributed.cc:170: in the call to 'getNextMsg', declared here
inline bool getNextMsg(std::string& haystack,
^| unsigned short priority; | ||
| worker(ip::address ipIn, unsigned short portIn, unsigned short priorityIn) | ||
| : ip(ipIn), port(portIn), priority(priorityIn) | ||
| Worker(ip::address ip, unsigned short port, unsigned short priority) |
There was a problem hiding this comment.
warning: consider replacing 'unsigned short' with 'uint16_t' [google-runtime-int]
Worker(ip::address ip, unsigned short port, unsigned short priority)
^| worker(ip::address ipIn, unsigned short portIn, unsigned short priorityIn) | ||
| : ip(ipIn), port(portIn), priority(priorityIn) | ||
| Worker(ip::address ip, unsigned short port, unsigned short priority) | ||
| : ip(ip), port(port), priority(priority) |
There was a problem hiding this comment.
warning: parameter 'ip' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
src/dst/src/LoadBalancer.h:13:
- #include <vector>
+ #include <utility>
+ #include <vector>| : ip(ip), port(port), priority(priority) | |
| : ip(std::move(ip)), port(port), priority(priority) |
| kDots | ||
| }; | ||
| virtual void setBrush(const Color& color, const Brush& style = SOLID) = 0; | ||
| virtual void setBrush(const Color& color, const Brush& style = kSolid) = 0; |
There was a problem hiding this comment.
warning: default arguments on virtual or override methods are prohibited [google-default-arguments]
virtual void setBrush(const Color& color, const Brush& style = kSolid) = 0;
^| } | ||
|
|
||
| void setBrush(const Color& color, const Brush& style = Brush::SOLID) override | ||
| void setBrush(const Color& color, const Brush& style = Brush::kSolid) override |
There was a problem hiding this comment.
warning: default arguments on virtual or override methods are prohibited [google-default-arguments]
void setBrush(const Color& color, const Brush& style = Brush::kSolid) override
^
2 participants
No description provided.