Remove useless _update field and add CHECKBLOCK for units#7809
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Jul 15, 2025
Faholan:defin_units
Merged
Remove useless _update field and add CHECKBLOCK for units#7809maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Faholan:defin_units
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Faholan:defin_units
Conversation
Signed-off-by: Faholan <62927863+Faholan@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Jul 15, 2025
maliberty
merged commit c04b952
into
The-OpenROAD-Project:master
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_updatefield of the reader is never updated and can thus be safely removed.The
setTechcallback doesn't have a CHECKBLOCK and thus segfaults if called before the design is set