gui: avoid pre-filling with (0,0) points#7811
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Jul 15, 2025
Merged
gui: avoid pre-filling with (0,0) points#7811maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Contributor
Author
Contributor
Author
|
I also noticed we use the same constructor type at |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSOC intern @gs-chaitanya is working on implementing rectlinear floorplans. During his work we noticed a bug, we get a DIE horizontal line going to the origin (0,0) even though the die does not touch the origin:

This PR fixes this issue. I noticed QPolygon initialization is pre-filling its values with multiple (0,0) values, we end up getting double the objects we would need:
Changing the constructor we use, we get the expected values only:
Finally, with the fix we get:
