Implement callback registry to enable inter-module communication throughout openroad. #7987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
osamahammad21
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| private: | ||
| TritonRoute* router_; |
Contributor
There was a problem hiding this comment.
warning: private field 'router_' is not used [clang-diagnostic-unused-private-field]
TritonRoute* router_;
^
Member
Author
There was a problem hiding this comment.
@maliberty Is it possible to ignore this? It's gonna be used in a following PR.
Member
There was a problem hiding this comment.
Ok though you could have saved it for the PR where it is used.
maliberty
requested changes
Aug 10, 2025
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
maliberty
reviewed
Aug 10, 2025
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
maliberty
approved these changes
Aug 11, 2025
Member
|
false bazel failure on download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.