Skip to content

Update sta#8451

Merged
maliberty merged 8 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update-sta
Sep 28, 2025
Merged

Update sta#8451
maliberty merged 8 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update-sta

Conversation

@openroad-ci
Copy link
Collaborator

No description provided.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty enabled auto-merge September 27, 2025 14:49
@maliberty
Copy link
Member

@oharboe how do I get test/orfs/mock-array to use the latest ORFS with my Verilator fix?

@maliberty
Copy link
Member

Nvm, I forgot to click auto-merge on that PR so it hadn't merged

@oharboe
Copy link
Collaborator

oharboe commented Sep 27, 2025

It is in the READMEs:

bazelisk run @bazel-orfs//:bump

@maliberty
Copy link
Member

Is the bazel-orfs version pinned in OR?

@oharboe
Copy link
Collaborator

oharboe commented Sep 27, 2025

Is the bazel-orfs version pinned in OR?

yes, see MODULE.bazel

@maliberty
Copy link
Member

So should I be bumping in bazel-orfs & OR both?

@maliberty
Copy link
Member

In OR it appears to just hang:

bazelisk run @bazel-orfs//:bump
Starting local Bazel server (8.3.1) and connecting to it...
INFO: Invocation ID: fa682bb1-9305-42bc-8a6d-dc0611eb1580
WARNING: WORKSPACE support will be removed in Bazel 9 (late 2025), please migrate to Bzlmod, see https://bazel.build/external/migration.
INFO: Analyzed target @@bazel-orfs+//:bump (148 packages loaded, 2073 targets configured).
INFO: Found 1 target...
Target @@bazel-orfs+//:bump up-to-date:
  bazel-bin/external/bazel-orfs+/bump
INFO: Elapsed time: 26.629s, Critical Path: 0.01s
INFO: 1 process: 5 action cache hit, 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/external/bazel-orfs+/bump
Latest tag: v3.0-3868-g832999cb0
v3.0-3868-g832999cb0: Pulling from openroad/orfs
Digest: sha256:01c6532234a4708847d1fe98d71dfc586d7566e5428bf7dfa23099bddf195f81
Status: Image is up to date for openroad/orfs:v3.0-3868-g832999cb0
docker.io/openroad/orfs:v3.0-3868-g832999cb0
Latest commit: acd76cb3d123e18ee1b65a632cd05be30b46fbbf
DEBUG: /workspace/bazel/output/external/rules_jvm_external+/private/extensions/maven.bzl:351:18: The maven repository 'maven' has contributions from multiple bzlmod modules, and will be resolved together: ["bazel-orfs", "openroad", "or-tools", "protobuf"]
 no actions running

with no cpu activity nor is it completed

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty
Copy link
Member

I ctlr-c'ed and got the update but it would be nice to get it to work more normally.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Collaborator

oharboe commented Sep 27, 2025

normally i bump both, use git add -p to pick one or the other if you dont want to bump both.

I cant recall not bumping both...

@maliberty
Copy link
Member

Having updated the module I still see the same error which is confusing. I have run it locally without error in ORFS so it is snarled in all this machinery. Would you help figure out what is wrong?

@maliberty
Copy link
Member

I finally see that you don't actually run mock-array from orfs but have a copy of the scripts in OR so I had to update the copy of power.tcl. Is there a reason we can't use one set of scripts?

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit f061eab into The-OpenROAD-Project:master Sep 28, 2025
13 checks passed
@maliberty maliberty deleted the update-sta branch September 28, 2025 02:24
@oharboe
Copy link
Collaborator

oharboe commented Sep 28, 2025

My plan is to retire MockArray in ORFS.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants