Fixed wrong netlist editing issues caused by dbModInst::swapMaster().#8684
Merged
maliberty merged 21 commits intoThe-OpenROAD-Project:masterfrom Oct 22, 2025
Merged
Conversation
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
- To fix nangate45/mempool_group issue Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
…ate/OpenROAD into secure-fix-swap-master Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
…ckSanity() instead. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
jhkim-pii
reviewed
Oct 20, 2025
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
…ang-tidy issue Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…ate/OpenROAD into secure-fix-swap-master Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
precisionmoon
approved these changes
Oct 22, 2025
Contributor
precisionmoon
left a comment
precisionmoon
left a comment
There was a problem hiding this comment.
Thanks much for adding a C++ testcase also.
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nets w/ multiple drivers caused STA crash in
nangate45/mempool_groupdesign.Causes
dbNetused wrong hierarchical names (dbNetshould have a full hierarchical name).dbNetname collision occurred, which caused nets with multiple drivers.Solution
dbNetwith correct hierarchical names.dbModInst::swapMaster()behavior significantly.Fixes #8601
Issue
src/odb/test/replace_hier_mod1.tcl.report_checks -throughandreplace_hier_modulecan cause the crash.replace_hier_mod1.tclto avoid the crash.