Skip to content

Added leetcode problem 10#1033

Merged
Panquesito7 merged 8 commits into
TheAlgorithms:masterfrom
itsyashvardhan:master
Nov 10, 2022
Merged

Added leetcode problem 10#1033
Panquesito7 merged 8 commits into
TheAlgorithms:masterfrom
itsyashvardhan:master

Conversation

@itsyashvardhan

@itsyashvardhan itsyashvardhan commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@itsyashvardhan

itsyashvardhan commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

@Panquesito7 can you please review my PR?

Panquesito7
Panquesito7 requested changes Oct 28, 2022
View reviewed changes

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts (for the leetcode/README.md file) here.
Let us know if you need any help here or on our Discord server! 🙂

Comment thread leetcode/src/10.c
@Panquesito7 Panquesito7 added enhancement New feature or request Changes requested Proper Documentation Required requested to write the documentation properly labels Oct 28, 2022
Panquesito7
Panquesito7 reviewed Nov 9, 2022
View reviewed changes
Comment thread leetcode/src/10.c Outdated
Comment thread leetcode/src/10.c Outdated
Comment thread leetcode/src/10.c
@Panquesito7 Panquesito7 added Leetcode folder changes Changes to Leetcode folder. Known CI issues. and removed Changes requested Proper Documentation Required requested to write the documentation properly labels Nov 9, 2022
Panquesito7
Panquesito7 previously approved these changes Nov 9, 2022
View reviewed changes

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

tjgurwara99
tjgurwara99 requested changes Nov 9, 2022
View reviewed changes

@tjgurwara99 tjgurwara99 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've forgotten to write tests for this implementation... EDIT: Seems that none of the algorithms do. I'll approve it in that case.

tjgurwara99
tjgurwara99 previously approved these changes Nov 9, 2022
View reviewed changes
@Panquesito7 Panquesito7 dismissed stale reviews from tjgurwara99 and themself via 1359aff November 10, 2022 01:22
@Panquesito7 Panquesito7 merged commit 68bdbfb into TheAlgorithms:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes
@tjgurwara99 tjgurwara99 tjgurwara99 left review comments

Assignees

No one assigned

Labels

enhancement New feature or request Leetcode folder changes Changes to Leetcode folder. Known CI issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsyashvardhan @tjgurwara99 @Panquesito7