Skip to content

[bugs/lgtm] code + doc fixes + lgtm corrections#552

Merged
kvedala merged 8 commits intoTheAlgorithms:masterfrom
kvedala:fixes/lgtm
Jul 2, 2020
Merged

[bugs/lgtm] code + doc fixes + lgtm corrections#552
kvedala merged 8 commits intoTheAlgorithms:masterfrom
kvedala:fixes/lgtm

Conversation

@kvedala
Copy link
Collaborator

@kvedala kvedala commented Jun 30, 2020

Description of Change

  • Fixed misc/cantor_set.c for lgtm errors
  • Fixed searching/binary_search.c for lgtm errors
  • fixed cmake - removed /Za option for MSVC compiler
  • added details section to project_euler/problem_1/sol1.c
  • fix lgtm error for project_euler/problem_401/sol1.c

References

Issue: #550, lgtm alert link

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@lgtm-com
Copy link

lgtm-com bot commented Jun 30, 2020

This pull request fixes 2 alerts when merging cc45bea into 74c091b - view on LGTM.com

fixed alerts:

  • 2 for Local variable hides global variable

@TheAlgorithms TheAlgorithms deleted a comment from lgtm-com bot Jun 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jun 30, 2020

This pull request fixes 2 alerts when merging 3b0ff5f into 74c091b - view on LGTM.com

fixed alerts:

  • 2 for Local variable hides global variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 30, 2020

This pull request fixes 2 alerts when merging e75dfb8 into 74c091b - view on LGTM.com

fixed alerts:

  • 2 for Local variable hides global variable

@kvedala kvedala closed this Jul 1, 2020
@kvedala kvedala reopened this Jul 1, 2020
refer: TheAlgorithms@dd40af2#r40309582
(cherry picked from commit 610181d)
@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2020

This pull request fixes 3 alerts when merging 2a0b891 into 74c091b - view on LGTM.com

fixed alerts:

  • 2 for Local variable hides global variable
  • 1 for Comparison result is always the same

@kvedala
Copy link
Collaborator Author

kvedala commented Jul 2, 2020

@tjgurwara99
@ayaankhan98
can anyone review these changes

@kvedala kvedala merged commit 0f48961 into TheAlgorithms:master Jul 2, 2020
@kvedala kvedala deleted the fixes/lgtm branch July 2, 2020 00:11
@tjgurwara99
Copy link
Member

Also edit the detail of this PR by adding the fix: problem_401/sol1.c to keep track of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants