Skip to content

Fix: Integer literal is too large to be represented as signed integer…#793

Merged
Panquesito7 merged 1 commit into
masterfrom
unknown repository
Feb 18, 2021
Merged

Fix: Integer literal is too large to be represented as signed integer…#793
Panquesito7 merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 3, 2021

Copy link
Copy Markdown

Fixed the warning integer literal is too large to be represented as singed integer. The file now compiles successfully.

Description of Change

In the file hash/hash_sdbm.c the integer literals ( in the line: 36, 38, 39 ) were too large to be signed and were error prone. Simply making them unsigned fixes the issue.

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@ghost

ghost commented Feb 3, 2021

Copy link
Copy Markdown
Author

Hey, I don't now as to why the third check is failing. And I can't figure it out given my little to no experience to open source. Could anyone help me with it? Any help appreciated!

@CarlosZoft

Copy link
Copy Markdown
Member

I have the same problem, I did a test. I sent a copy of the main branch as a pull request, returned the same error.
I believe it is something with the current version of the main branch

@Panquesito7

Copy link
Copy Markdown
Member

The third check (Windows checks) has been removed (#796), so the checks in this PR shouldn't fail anymore. 🙂

@Panquesito7 Panquesito7 added the enhancement New feature or request label Feb 17, 2021

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this: with and without your changes and the tests still pass. 🤔

@ghost

ghost commented Feb 17, 2021

Copy link
Copy Markdown
Author

Hi @Panquesito7, yeah you're right. But when I individually compile the hash_sdbm.c file, I receive the above-mentioned error. Attaching a screenshot for your reference. I'm sorry for the ambiguity. I could've been more precise.
Screenshot from 2021-02-17 09-45-10

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Feb 18, 2021
@Panquesito7 Panquesito7 merged commit 3a85f72 into TheAlgorithms:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants