Fix: Integer literal is too large to be represented as signed integer…#793
Conversation
|
Hey, I don't now as to why the third check is failing. And I can't figure it out given my little to no experience to open source. Could anyone help me with it? Any help appreciated! |
|
I have the same problem, I did a test. I sent a copy of the main branch as a pull request, returned the same error. |
|
The third check (Windows checks) has been removed (#796), so the checks in this PR shouldn't fail anymore. 🙂 |
Panquesito7
left a comment
There was a problem hiding this comment.
I tested this: with and without your changes and the tests still pass. 🤔
|
Hi @Panquesito7, yeah you're right. But when I individually compile the hash_sdbm.c file, I receive the above-mentioned error. Attaching a screenshot for your reference. I'm sorry for the ambiguity. I could've been more precise. |
Panquesito7
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution! 👍 🎉

Fixed the warning integer literal is too large to be represented as singed integer. The file now compiles successfully.
Description of Change
In the file hash/hash_sdbm.c the integer literals ( in the line: 36, 38, 39 ) were too large to be signed and were error prone. Simply making them unsigned fixes the issue.
Checklist