ci: slim apt-get system-lib lists to libhdf5-dev only (and use --yes) - #15157
Conversation
Modern wheels (pillow, lxml, h5py, numpy/scipy, matplotlib) ship self-contained manylinux/musllinux wheels, so the long lists of -dev system libraries (libtiff/libjpeg/libopenjp2/freetype/harfbuzz/xml/ xslt/openblas/tk, etc.) are no longer needed to install or import the project's dependencies. Reduce each apt-get step to libhdf5-dev only (kept for now as a first step) and switch the deprecated -y flag to --yes. If CI stays green a follow-up can drop libhdf5-dev too, since h5py 3.16 ships wheels with a bundled HDF5 and nothing imports h5py directly.
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
|
CI is fully green with the lists trimmed to As planned, once this lands I'll send a tiny follow-up dropping |
algorithms-keeper
Bot
removed
the
awaiting reviews
Follow-up to #15157. h5py ships self-contained manylinux/musllinux wheels (aarch64 included) that bundle their own HDF5, so no system libhdf5 is needed to import or use it. Removing the apt-get step speeds up CI and removes a network dependency; CI will confirm.
2 participants
Per @cclauss's suggestion to trim the
apt-get installlists in our workflows.What
project_euler.yml(both jobs) andsphinx.ymlcurrently install a long list of-devsystem libraries (libtiff/libjpeg/libopenjp2/zlib/freetype/lcms2/webp/tcl/tk/python3-tk/harfbuzz/fribidi/xcb/xml2/xslt/hdf5/openblas). This PR reduces each tolibhdf5-devonly.-yflag to--yesin all three workflows (build.ymlincluded).Why it's safe
Those
-devpackages existed to build dependencies from source. The project's deps now all ship self-contained manylinux/musllinux wheels:Nothing in the tree
importsh5pydirectly (only a commentedcnn.h5line), solibhdf5-devis very likely droppable too — but I kept it for this first step exactly as suggested ("drop all packages except libhdf5-dev and see if tests pass"). If CI is green here, I'll open a tiny follow-up removinglibhdf5-devas well.Letting CI be the empirical test.