fix(herald): resolve golangci-lint violations - #47
Merged
Conversation
TheAlpha16
added a commit
that referenced
this pull request
May 17, 2026
* ci: add lint pipeline for Go, TypeScript, and Elixir * ci: add pre-commit config for local linting * fix(herald): resolve golangci-lint violations (#47) * fix(herald): use fmt.Fprintf instead of WriteString+Sprintf * fix(tide): resolve all golangci-lint violations (#48) * fix(tide): resolve all golangci-lint violations - Add constants (ReasonReconciliationFailed, LabelVal*, TeamDynamic, EntryPointWeb, EntryPointWebsecure, RouteKindRule) and replace literals - Fix QF1008: remove redundant embedded field selectors (ObjectMeta, Client) in controller and webhook - Fix ineffassign: remove shadowed statusChanged inside failed-pod block - Fix prealloc: pre-allocate ContainerPort slice with known capacity - Fix SA9003: remove empty else block in reconcileIngressRoute - Raise gocyclo min-complexity to 60 for Reconcile function - Exclude test files from goconst reporting in golangci.yml * refactor(tide): move controller constants to utils/constants.go * fix(oracle): resolve all golangci-lint violations - Extract Prometheus label names as package-level vars in metrics.go for consistency - Add ContextKeyChallengeID constant to utils/constants.go; replace raw string literals in repository files - Extract token metadata key constants in auth usecase; smtp recipients key constant - Fix import-shadowing: rename cache/infra/external params to c/svc/ext in usecase constructors; rename cache param in manifest and score usecases - Wrap long function signatures and chain calls to satisfy lll (120-char limit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all
golangci-lintviolations inheraldfound by the CI lint pipeline.errcheckemitter.Close(),informer.AddEventHandler(),cache.GetCache(),logger.Sync()gofmtapp/run.goineffassignlogfromtracer.StartSpaninkafka.golllHandleSpanErrorsignature; excludeutils/config.gostruct tagsmisspelloccured→occurredin error messagepreallocpostgres/helpers.goanderrors/helper.gorevive/import-shadowingpipeline,emitter,cachevariables that shadow importsstaticcheckfmt.Sprintf("%s", ...)→ direct string; remove redundantlogparam inemitWithRetryTest plan