Skip to content

Fix: Added Render static affordance to CMS Filter - #38

Merged
JorchCortez merged 1 commit into
Developfrom
Feature-adding-render-static-affordance-to-CMSFilter
Jan 3, 2025
Merged

Fix: Added Render static affordance to CMS Filter#38
JorchCortez merged 1 commit into
Developfrom
Feature-adding-render-static-affordance-to-CMSFilter

Conversation

@JorchCortez

Copy link
Copy Markdown
Contributor

New Feature: [Feature Title]

Description

when using CMS filter along with RenderStatic an issue shows up in which the result count shows the total of results + the render-static results ONLY WHEN NO FILTERS SELECTED, added an affordance to prevent this from happening

Script Details

  • Script Name: CMS Filter
  • Purpose of Update: see description for full reasons
  • New Behavior: when no filters are selected and using Render Static + CMS Filter the static elements are not counted in the results count

Changes Made

  • Updated the CMSFilter's getResults function adding a filtering to take out the elements with the renderstatic attribute so both scripts can work together

This PR closes NONE

Checklist

  • Feature has been tested locally with all relevant use cases.
  • Documentation has been updated (if necessary).
  • PR does not match another non-stale PR currently opened
  • PR name matches the format [ Fix ]: Fix Name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your Feature matches the standards laid out here

when using CMS filter along with RenderStatic an issue shows up in which the result count shows the total of results + the render-static results ONLY WHEN NO FILTERS SELECTED, added an affordance to prevent this from happening
@JorchCortez
JorchCortez merged commit e3bf1ad into Develop Jan 3, 2025
@JorchCortez
JorchCortez deleted the Feature-adding-render-static-affordance-to-CMSFilter branch January 3, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant