You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
A repaid debt reads as settled, and the Undo bar goes away (#115)
* A repaid debt reads as settled, and the Undo bar goes away
Three things, two of them bugs visible on one screen.
The Outstanding filter was reading the debt's stored `status` field, which
is only written when a debt is settled through the repayment sheet. Clear
a debt any other way — a repayment line typed on an ordinary transaction,
an imported statement, an edit — and the field still says "open" while
the balance says zero. A fully repaid informal loan sat in the
Outstanding list showing a dash for its balance.
Status now follows the money. The stored field can still close a debt
early, for one written off or settled in kind, but it can no longer keep
a cleared one open. That is the same rule dues already use, and it fixes
the filter, the status badge on the row, the badge on the contact page,
the detail sheet, and the open-debt count.
An overpaid debt deliberately still counts as outstanding: a negative
balance is a discrepancy worth seeing, not something to file away.
The "Due deleted / Undo" bar never went away, and Flutter is why:
persist = persist ?? action != null;
Any SnackBar with an action defaults to never timing out, so the six
second duration this bar was given had been ignored since the day it
gained an Undo button. It now passes persist: false, and carries a close
button, because a bar that can linger needs a way out that is not a
guessed swipe. A test pins the framework default too, so if that ever
changes the workaround can go.
On the accounts list, a tap now opens the ledger rather than the metadata
sheet. That sheet has not been dropped: it moves into the long-press menu
alongside the account's other actions, where it is reachable rather than
being what a tap lands on.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016jkAcgzuuxTfBiAgMLWgC4
* Leave the accounts list alone: swipe already opens the ledger
Tap was changed to open the ledger, which duplicated the left swipe that
already does exactly that, and cost the metadata sheet its place. Both
are back as they were: tap opens the account's details, swipe left opens
the ledger, and the long-press menu is unchanged.
The two fixes this branch carries are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016jkAcgzuuxTfBiAgMLWgC4
---------
Co-authored-by: Claude <noreply@anthropic.com>