fix PHP notice: "Undefined variable: emptyOption" #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsure what the purpose of the if-statement is, but fix the warning though
Member
|
Thanks @infabo, I went ahead and removed the whole line as I don't believe it's doing anything most likely just left over code from the template I used. I'm sure your right and the first if statement always runs and we don't need the rest of the code. But since it's working and not producing warnings i'll leave the remaining code as is for now as don't have all the time to test. Will release a new version this evening. |
Contributor
Author
|
maybe add a new release tag? |
Member
|
Good call - sorry for the slow response here - this is now done. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsure what the purpose of the if-statement is, but fix the warning though