fix: avoid warning for Bing home page - #555
Merged
Merged
Conversation
Skip generic login-state detection on the normal Bing home page so successful session verification is not logged as an unknown page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
verifyBingSession()called the generic login-state detection before checking whether the browser had already reachedwww.bing.com/.The normal Bing home page does not contain the login-page selectors used by
detectCurrentState(), so it was reported asUNKNOWN. The same loop then correctly recognized the Bing home page and verified the session successfully.This caused a misleading warning:
Changes
Testing