Skip to content

fix: update app router path handling for Windows and bump ruleset version#8

Open
robert-dudley-p1 wants to merge 1 commit into
TheOrcDev:mainfrom
robert-dudley-p1:fix/windows-app-router-paths
Open

fix: update app router path handling for Windows and bump ruleset version#8
robert-dudley-p1 wants to merge 1 commit into
TheOrcDev:mainfrom
robert-dudley-p1:fix/windows-app-router-paths

Conversation

@robert-dudley-p1

@robert-dudley-p1 robert-dudley-p1 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

Fix Windows path handling for Next.js App Router rules.

Changes

  • Normalize App Router glob paths to /.
  • Fix metadata file discovery across Windows path separators.
  • Reuse shared path handling for route boundary checks.
  • Bump ruleset to 2026.07.36.
  • Update generated rule catalog and changelog.

Validation

  • Targeted tests: 25/25 passed.
  • Typecheck, formatting, docs check, and CLI build passed.
  • Full CLI suite has unrelated Windows environment failures.

Closes #7

Summary by CodeRabbit

  • Bug Fixes

    • Improved App Router analysis on Windows by correctly discovering route boundaries and metadata exports.
    • Improved detection of metadata files within the application directory, including root-level metadata.
    • Corrected route pattern matching across platforms for error and not-found boundaries.
  • Chores

    • Updated the bundled static-analysis ruleset to version 2026.07.36.
    • Updated the rules documentation to reflect the latest ruleset version.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

@robert-dudley-p1 is attempting to deploy a commit to the OrcDev Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f92ed20-cdc5-4754-959d-fd728c6dc400

📥 Commits

Reviewing files that changed from the base of the PR and between c4cc3fe and a68417e.

⛔ Files ignored due to path filters (1)
  • lib/generated/rule-catalog.json is excluded by !**/generated/**
📒 Files selected for processing (6)
  • CHANGELOG.md
  • docs/rules.md
  • packages/cli/src/rules/high-confidence.ts
  • packages/cli/src/rules/metadata-title-description-complete.ts
  • packages/cli/src/rules/source-files.ts
  • packages/cli/src/scan.ts

📝 Walkthrough

Walkthrough

App Router rule discovery now handles Windows path separators for route boundaries and metadata files. Metadata matching uses resolved relative paths, and the bundled ruleset version is updated to 2026.07.36.

Changes

App Router Windows path handling

Layer / File(s) Summary
Normalize App Router route patterns
packages/cli/src/rules/source-files.ts, packages/cli/src/rules/high-confidence.ts
App Router route globs use POSIX separators, and the not-found and error boundary rules consume the shared pattern helper.
Resolve metadata paths against the app directory
packages/cli/src/rules/metadata-title-description-complete.ts
Metadata candidates and root metadata are matched using resolved absolute paths and relative-path checks.
Publish the updated ruleset version
packages/cli/src/scan.ts, docs/rules.md, CHANGELOG.md
The bundled ruleset version is incremented to 2026.07.36 and recorded in documentation and the changelog.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: theorcdev

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the Windows App Router path fix and ruleset bump.
Linked Issues check ✅ Passed The changes address both Windows path-separator bugs in the App Router rules.
Out of Scope Changes check ✅ Passed The changelog, docs, and ruleset version updates all support the same fix and stay in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheOrcDev

Copy link
Copy Markdown
Owner

Hey @robert-dudley-p1

thanks for this one! please solve conflicts, and I'll merge right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows path separators cause false failures in App Router rules

2 participants