Improve some SAML error responses (PP-3507)#2997
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
- Coverage 92.93% 92.93% -0.01%
==========================================
Files 453 453
Lines 42957 42956 -1
Branches 5989 5988 -1
==========================================
- Hits 39923 39922 -1
Misses 1966 1966
Partials 1068 1068 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
tdilauro
added a commit
that referenced
this pull request
Jan 21, 2026
## Description Replace deprecated `setParseAction` with newer `set_parse_action` in the SAML Python DSL parser. No logic or other changes are included in this PR. ## Motivation and Context While testing #2997, I noticed a lot of deprecation warnings like this one in the output: ``` src/palace/manager/integration/patron_auth/saml/python_expression_dsl/parser.py:55 /Users/Shared/src/tpp/circulation/src/palace/manager/integration/patron_auth/saml/python_expression_dsl/parser.py:55: DeprecationWarning: 'setParseAction' deprecated - use 'set_parse_action' NEGATION_OPERATOR = Literal("-").setParseAction(lambda _: Operator.NEGATION) ``` ## How Has This Been Tested? All tests continue to pass, both locally and [in CI](https://github.com/ThePalaceProject/circulation/actions/runs/21214944881). ## Checklist - N/A I have updated the documentation accordingly. - [x] All new and existing tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Some of our authentication failure problem detail messages are overly focused on username/password or barcode/PIN credentialed login mechanisms. For example, one problem document received by a SAML patron contained this
detailtext:[Jira PP-3507]
How Has This Been Tested?
Checklist