Skip to content

Update deprecated setParseAction method calls#2998

Merged
tdilauro merged 1 commit intomainfrom
bugfix/saml-dsl-parser-warnings
Jan 21, 2026
Merged

Update deprecated setParseAction method calls#2998
tdilauro merged 1 commit intomainfrom
bugfix/saml-dsl-parser-warnings

Conversation

@tdilauro
Copy link
Contributor

Description

Replace deprecated setParseAction with newer set_parse_action in the SAML Python DSL parser.

No logic or other changes are included in this PR.

Motivation and Context

While testing #2997, I noticed a lot of deprecation warnings like this one in the output:

src/palace/manager/integration/patron_auth/saml/python_expression_dsl/parser.py:55
  /Users/Shared/src/tpp/circulation/src/palace/manager/integration/patron_auth/saml/python_expression_dsl/parser.py:55: DeprecationWarning: 'setParseAction' deprecated - use 'set_parse_action'
    NEGATION_OPERATOR = Literal("-").setParseAction(lambda _: Operator.NEGATION)

How Has This Been Tested?

All tests continue to pass, both locally and in CI.

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team January 21, 2026 15:27
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (592b679) to head (ddc61bb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2998   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files         453      453           
  Lines       42957    42957           
  Branches     5989     5989           
=======================================
  Hits        39921    39921           
  Misses       1967     1967           
  Partials     1069     1069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tdilauro tdilauro merged commit 51ec6cc into main Jan 21, 2026
19 checks passed
@tdilauro tdilauro deleted the bugfix/saml-dsl-parser-warnings branch January 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants