Skip to content

Add ROT 13 in Go #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrg94 merged 2 commits into from
Mar 18, 2019
Merged

Add ROT 13 in Go #1012

jrg94 merged 2 commits into from
Mar 18, 2019

Conversation

@auroq
Copy link
Contributor

@auroq auroq commented Mar 18, 2019

Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!

For simplicity, please make sure that your pull request includes one and only one sample program and language.

Please Complete the Following

  • I would NOT like credit for my contribution in the article (credit will be included otherwise)
  • I plan to write the article for this code snippet
  • I named the pull request using <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)
  • I fixed Add ROT 13 in Go #1010

Notes

Feel free to put whatever you want here.

@auroq auroq added enhancement Any code that improves the repo rot13 See: https://sampleprograms.io/projects/rot13/ labels Mar 18, 2019
@auroq auroq added this to the 500 Code Snippets milestone Mar 18, 2019
@jrg94 jrg94 requested a review from a team March 18, 2019 19:09
@jrg94 jrg94 self-assigned this Mar 18, 2019
jrg94
jrg94 approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Good ol' rot-13. 🤖

jrg94
jrg94 reviewed Mar 18, 2019
View reviewed changes
archive/g/go/rot-13.go
)

func rot13(str string) string {
return strings.Map(encryptRune, str)
Copy link
Member

@jrg94 jrg94 Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean functional code here! 👍 beats the hell out of looping over the terms yourself.

@jrg94 jrg94 merged commit cb426c5 into master Mar 18, 2019
@jrg94 jrg94 deleted the go-rot13 branch March 18, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels

enhancement Any code that improves the repo rot13 See: https://sampleprograms.io/projects/rot13/

Projects

Code Snippets
Archived in project

Milestone

500 Code Snippets

Development

Successfully merging this pull request may close these issues.

Add ROT 13 in Go

3 participants

@auroq @jrg94