Skip to content

Added Roman Numeral in Python Article#1788

Merged
jrg94 merged 3 commits intoTheRenegadeCoder:masterfrom
rayavarapuvikram1:master
Oct 27, 2019
Merged

Added Roman Numeral in Python Article#1788
jrg94 merged 3 commits intoTheRenegadeCoder:masterfrom
rayavarapuvikram1:master

Conversation

@rayavarapuvikram1
Copy link
Contributor

  1. Added 2019-10-27-python.md to roman-numeral-conversion directory.
  2. Modified a comment in code(line 43) and converted var= var + 4 to var +=4

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

1. Added 2019-10-27-python.md to roman-numeral-conversion directory.
2. Modified a comment in code(line 43) and converted var= var + 4 to var +=4
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a copy logistics issues.

@jrg94 jrg94 self-assigned this Oct 27, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/ labels Oct 27, 2019
@jrg94 jrg94 changed the title Added roman_numeral_article. Added Roman Numeral in Python Article Oct 27, 2019
@jrg94 jrg94 added this to the 200 Articles milestone Oct 27, 2019
Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>
@rayavarapuvikram1
Copy link
Contributor Author

Can it be committed now?

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready!

Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Woo!

@jrg94 jrg94 merged commit fdd3a5f into TheRenegadeCoder:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants