Skip to content

Added Factorial in Rust#1831

Merged
jrg94 merged 2 commits intoTheRenegadeCoder:masterfrom
msj2:patch-5
Nov 4, 2019
Merged

Added Factorial in Rust#1831
jrg94 merged 2 commits intoTheRenegadeCoder:masterfrom
msj2:patch-5

Conversation

@msj2
Copy link
Contributor

@msj2 msj2 commented Oct 31, 2019

accept a number on command line (works till 34)
print it's factorial.

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • [X ] I named the pull request using Added/Updated <Sample Program> in <Language> format
  • [] I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Accept a number on the command line and return the factorial of the number.

msj2 added 2 commits October 31, 2019 17:25
accept a number on command line (works till 34)
print it's factorial.
@jrg94 jrg94 requested a review from a team October 31, 2019 17:23
@jrg94 jrg94 self-assigned this Oct 31, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related labels Oct 31, 2019
@jrg94 jrg94 modified the milestones: 50 Projects, 500 Code Snippets Oct 31, 2019
@jrg94 jrg94 changed the title Return Factorial of number (less than 35) Added Factorial in Rust Nov 1, 2019
@msj2
Copy link
Contributor Author

msj2 commented Nov 4, 2019

waiting.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close! We'll have to loop in some testing in the future to confirm, however.

@jrg94 jrg94 merged commit f557d6e into TheRenegadeCoder:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Factorial in Rust

2 participants