Updated Prime Number in Python#1861
Merged
jrg94 merged 1 commit intoTheRenegadeCoder:masterfrom Feb 4, 2020
matthewbegun:patch-1
Merged
Updated Prime Number in Python#1861jrg94 merged 1 commit intoTheRenegadeCoder:masterfrom matthewbegun:patch-1
jrg94 merged 1 commit intoTheRenegadeCoder:masterfrom
matthewbegun:patch-1
Conversation
This drove me a little crazy this afternoon with bizarre 404s. Either the document needs to change the `-` to `_` or the filename needs to be changed. It is [prime_number.py](https://github.com/TheRenegadeCoder/sample-programs/blob/master/archive/p/python/prime_number.py). Awesome project, thanks!
jrg94
approved these changes
Feb 4, 2020
Member
jrg94
left a comment
jrg94
left a comment
There was a problem hiding this comment.
Nice catch! There's a handful of these quality control issues. All Python files should have the underscore syntax. Any chance you could patch that up as well?
Contributor
Author
|
I'll see what I can do :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>formatDocumentation
Added/Updated <Sample Program> in <Language> ArticleformatTesting
Added/Updated <Language>/<Project> TestingformatNotes
Feel free to describe what you added or updated.
Fix typo in file name.
This drove me a little crazy this afternoon with bizarre 404s. Either the document needs to change the
-to_or the filename needs to be changed.It is prime_number.py.
Awesome project, thanks!