Skip to content

Added Bubble Sort in VB#1976

Merged
jrg94 merged 4 commits intoTheRenegadeCoder:masterfrom
Bracciata:Visual-Basic-Bubble-Sort
Oct 2, 2020
Merged

Added Bubble Sort in VB#1976
jrg94 merged 4 commits intoTheRenegadeCoder:masterfrom
Bracciata:Visual-Basic-Bubble-Sort

Conversation

@Bracciata
Copy link
Contributor

@Bracciata Bracciata commented Oct 1, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 1, 2020 23:42
@jrg94 jrg94 self-assigned this Oct 1, 2020
@jrg94 jrg94 added bubble sort See: https://sampleprograms.io/projects/bubble-sort/ enhancement Any code that improves the repo labels Oct 1, 2020
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 1, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Double check the program requirements: https://sample-programs.therenegadecoder.com/projects/bubble-sort/

This program should accept an array on the command line (if possible). I don't know how VB handles stuff.

For the person who writes the article command line arguments were added using this guide https://dailydotnettips.com/how-to-pass-command-line-arguments-using-visual-studio/
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jrg94 jrg94 merged commit 2994ed9 into TheRenegadeCoder:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bubble sort See: https://sampleprograms.io/projects/bubble-sort/ enhancement Any code that improves the repo

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Bubble Sort in Visual Basic

2 participants