Skip to content

Edited Game of Life in Python#254

Merged
jrg94 merged 26 commits intoTheRenegadeCoder:masterfrom
2Clutch:master
Mar 28, 2020
Merged

Edited Game of Life in Python#254
jrg94 merged 26 commits intoTheRenegadeCoder:masterfrom
2Clutch:master

Conversation

@2Clutch
Copy link
Contributor

@2Clutch 2Clutch commented Jul 2, 2018

Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!

For simplicity, please make sure that your pull request includes one and only one sample program and language.

Please Complete the Following

  • I would NOT like credit for my contribution in the article (credit will be included otherwise)
  • I plan to write the article for this code snippet
  • I named the pull request using <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
  • I fixed #your-issue-number-here

Notes

Just a little background, I knew little about "The Game of Life" before working on this. I'm sure not sure I understand it, but that's beyond the point.

I tried to implement it using canvas as requested per the issue. However while my code looks fine to me, the GUI is not responding for whatever reason. I added a start and stop feature for convenience.

When the program is ran from the command line, the GUI loads up as expected with no issue. When I press start however, the program crashes and I have to exit my terminal prompt to bring things back to normal.

If you could please take a look and provide some feedback, I'd sincerely appreciate it. I'm stuck and I am not sure what to do next.

@jrg94
Copy link
Member

jrg94 commented Jul 2, 2018

Awesome! I'm excited to see you've tackled #110. I'll take a look, but I'm really not well versed in tk at all. I find the library a little clunky.

@jrg94 jrg94 self-requested a review July 2, 2018 20:53
@jrg94 jrg94 added enhancement Any code that improves the repo game of life labels Jul 2, 2018
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I opened everything up in PyCharm, there appeared to be a couple sections of unreachable code. Also, I noticed a few variables where their reference couldn't be found, but that may just be a typing issue.

@2Clutch
Copy link
Contributor Author

2Clutch commented Jul 2, 2018

Just went and fixed the begin_id issue. I had called it begin_id that in the beginning, but renamed it game_id and forgot to update it there. I use Sublime Text as an editor. I will look around for a PythonLinter plugin of sort and trying to work things through.

@jrg94
Copy link
Member

jrg94 commented Jul 2, 2018

Sounds good! I'll keep playing a bit. I see the grid shows up, and I noticed your debugs are pretty helpful.

@jrg94 jrg94 changed the title Game of Life in Python Edited Game of Life in Python Aug 14, 2018
@jrg94 jrg94 self-assigned this Aug 14, 2018
@jrg94
Copy link
Member

jrg94 commented Sep 15, 2018

We haven't touched this for a few months, so I'm going to close this for now.

@jrg94 jrg94 closed this Sep 15, 2018
@jrg94 jrg94 mentioned this pull request Dec 5, 2018
9 tasks
@jrg94 jrg94 reopened this Mar 26, 2020
@jrg94
Copy link
Member

jrg94 commented Mar 26, 2020

And, we're back! 💃

@2Clutch 2Clutch requested a review from jrg94 March 26, 2020 22:25
@jrg94
Copy link
Member

jrg94 commented Mar 28, 2020

Just now getting a chance to look this over.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is great. I'm going to rename the file for consistency, but this runs great otherwise. I noticed it goes to the console instead of as a full GUI, and I think that's fine.

@@ -0,0 +1,8 @@
string = str(input("Enter the string:"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this file! I didn't realize until now that it was sitting in root.

@jrg94 jrg94 merged commit b396de4 into TheRenegadeCoder:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants