Edited Game of Life in Python#254
Edited Game of Life in Python#254jrg94 merged 26 commits intoTheRenegadeCoder:masterfrom 2Clutch:master
Conversation
… cell in the grid
…for the day. So I am pushing this for the time being
|
Awesome! I'm excited to see you've tackled #110. I'll take a look, but I'm really not well versed in tk at all. I find the library a little clunky. |
jrg94
left a comment
There was a problem hiding this comment.
When I opened everything up in PyCharm, there appeared to be a couple sections of unreachable code. Also, I noticed a few variables where their reference couldn't be found, but that may just be a typing issue.
|
Just went and fixed the |
|
Sounds good! I'll keep playing a bit. I see the grid shows up, and I noticed your debugs are pretty helpful. |
|
We haven't touched this for a few months, so I'm going to close this for now. |
|
And, we're back! 💃 |
|
Just now getting a chance to look this over. |
jrg94
left a comment
There was a problem hiding this comment.
Overall, I think this is great. I'm going to rename the file for consistency, but this runs great otherwise. I noticed it goes to the console instead of as a full GUI, and I think that's fine.
| @@ -0,0 +1,8 @@ | |||
| string = str(input("Enter the string:")) | |||
There was a problem hiding this comment.
Thanks for moving this file! I didn't realize until now that it was sitting in root.
Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!
For simplicity, please make sure that your pull request includes one and only one sample program and language.
Please Complete the Following
<Sample Program> in <Language>formatNotes
Just a little background, I knew little about "The Game of Life" before working on this. I'm sure not sure I understand it, but that's beyond the point.
I tried to implement it using canvas as requested per the issue. However while my code looks fine to me, the GUI is not responding for whatever reason. I added a
startandstopfeature for convenience.When the program is ran from the command line, the GUI loads up as expected with no issue. When I press
starthowever, the program crashes and I have to exit my terminal prompt to bring things back to normal.If you could please take a look and provide some feedback, I'd sincerely appreciate it. I'm stuck and I am not sure what to do next.