Skip to content

Conversation

@rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Nov 12, 2023

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding New Tests for a Language

  • I fixed Add Factor Testing #3527
  • I named the pull request using Add {LANGUAGE} Tests format
  • I added a testinfo.yml files (see contributing documentation)
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

Other Notes

I had to modify the "Hello World" sample program to get the tests to pass.

@rzuckerm rzuckerm added enhancement Any code that improves the repo tests Testing related labels Nov 12, 2023
@rzuckerm rzuckerm marked this pull request as ready for review November 12, 2023 14:00
@jrg94 jrg94 requested a review from a team November 13, 2023 19:12
@jrg94 jrg94 self-assigned this Nov 13, 2023
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jrg94 jrg94 merged commit 9ba048a into TheRenegadeCoder:main Nov 13, 2023
@rzuckerm rzuckerm deleted the add-factor-tests branch November 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Factor Testing

2 participants