Add Baklava in Elvish

[Kaamkiya]

I Am Adding a New Code Snippet in an Existing Language

• I fixed Add Baklava in Elvish #4209
• I named the pull request using Add {PROJECT} in {LANGUAGE} format

[Kaamkiya]

I see the error. I'll fix it.

[Kaamkiya]

This is weird. I tried it in the official playground and it works. It also works on my computer. I wonder what's wrong here?

[Kaamkiya]

It seems to be outputting this:

[ERROR 2025-01-07 02:31:52 UTC] +--------------------------------------------------------+
[ERROR 2025-01-07 02:31:52 UTC] | Syntax error in file baklava.elv, line 3, column 7     |
[ERROR 2025-01-07 02:31:52 UTC] | 1: # By github.com/Kaamkiya                            |
[ERROR 2025-01-07 02:31:52 UTC] | 2:                                                     |
[ERROR 2025-01-07 02:31:52 UTC] | 3: for i [(range 11) (range 9 -1)] {                   |
[ERROR 2025-01-07 02:31:52 UTC] |          ^                                             |

But this is, in fact, valid elvish syntax. Any idea what could be causing this?

@jrg94

[rzuckerm]

It seems to be outputting this:

[ERROR 2025-01-07 02:31:52 UTC] +--------------------------------------------------------+
[ERROR 2025-01-07 02:31:52 UTC] | Syntax error in file baklava.elv, line 3, column 7     |
[ERROR 2025-01-07 02:31:52 UTC] | 1: # By github.com/Kaamkiya                            |
[ERROR 2025-01-07 02:31:52 UTC] | 2:                                                     |
[ERROR 2025-01-07 02:31:52 UTC] | 3: for i [(range 11) (range 9 -1)] {                   |
[ERROR 2025-01-07 02:31:52 UTC] |          ^                                             |

But this is, in fact, valid elvish syntax. Any idea what could be causing this?

@jrg94

@Kaamkiya The docker image for Elvish seems like it may be a very old version of the language. I found an official docker image here. What you can do is change these lines in archive/e/elvish/testinfo.yml to this:

  image: "ghcr.io/elves/elvish"
  tag: "v0.21.0"

Also, I'd like to recommend that you keep the main branch of your fork clean so that you can resync it to the main branch of this repo without losing any of your work. I'd recommend creating a different branch for each sample program that you contribute based on the main branch. For instance, I created a baklava-forth branch for my "Add Baklava in Forth" PR.

[rzuckerm]

Looks good, @Kaamkiya . Thanks for your contribution! I'll merge this when you mark the PR ready for review

[Kaamkiya]

@rzuckerm

change these lines in archive/e/elvish/testinfo.yml

Oh, that would make sense. I've done that now.

creating a different branch for each sample program

I realize now that I should have done that. I'll keep it in mind for next time.